pqienso / pe

0 stars 0 forks source link

DG sequence diagram: wrong syntax #16

Open pqienso opened 3 months ago

pqienso commented 3 months ago

Screenshot 2024-04-19 174050.png :ui calls the method of parser, which calls the method of the Meal class. Yet, the result bypasses :parser and immediately returns back from Meal to :ui. This is not possible and is likely incorrect syntax.

Additionally, the 3 arrows between parser and Meal do not make any sense (1 is a dotted arrow but is labelled as a function call, and 1 says "return name" but is a solid arrow).

soc-pe-bot commented 3 months ago

Team's Response

The result does not have to be passed through the parser

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is not the way sequence diagrams were taught to us. Even if the result is not passed through parser, the control of the program should still be returned to parser, not directly back to :ui.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** I think the severity should be at least medium as I genuinely have trouble understanding the diagram and how the function runs due to the syntax errors in the diagram.