pqina / filepond

🌊 A flexible and fun JavaScript file upload library
https://pqina.nl/filepond
MIT License
15.18k stars 828 forks source link

[Bug] Safari click on custom idleLabel prop requires 2 clicks to trigger file upload dialog #975

Open sparkcodeuk opened 6 months ago

sparkcodeuk commented 6 months ago

Is there an existing issue for this?

Have you updated FilePond and its plugins?

Describe the bug

When you have a custom labelIdle prop specified, on Safari desktop in OSX at least it requires 2 clicks to get the OS file dialog prompt if you click the label itself.

It appears to be a Safari desktop specific bug (tested with version 17.4.1 on OSX 14.4.1).

On Chrome & Firefox is works as expected, requiring only a single click no matter where you click in the filepond component, this appears to be Safari specific.

I have not had the time to test on mobile, no other browsers not listed or other operating systems.

Reproduction

The labelIdle prop used to test this bug was a simple string value (i.e., no HTML required and the presence of a <span class="filepond--label-action"> tag does not alter the behaviour of this issue).

Environment

- Device: Desktop
- OS: OSX 14.4.1 (Sonoma)
- Browser: Safari (17.4.1) this appears to be a Safari specific bug