pqina / vue-filepond

🔌 A handy FilePond adapter component for Vue
https://pqina.nl/filepond
MIT License
1.91k stars 128 forks source link

v6.0.3 change breaks usage with Vite #258

Open dbruning opened 2 years ago

dbruning commented 2 years ago

Is there an existing issue for this?

Have you updated Vue FilePond, FilePond, and all plugins?

Describe the bug

To fix #122 vue-filepond v6.0.3 introduced a change to replace: import Vue from 'vue' with: import Vue from 'vue/dist/vue.esm';

Unfortunately this fix breaks the usage of vue-filepond under vite. It causes Vite to include a complete new copy of Vue, which basically re-introduces exactly the problem that #122 was trying to solve ("$attrs is readonly")

The workaround is just to go back to v6.0.2 under Vite. I'm not knowledgeable enough to know how to make a change that will work under both vue-clie(/webpack) and Vite; but hopefully this will help someone in future.

Reproduction

Try to use vue-filepond with vue2 and vite

Environment

- Device: Windows PC
- OS: Windows
- Browser: any
- Vue version: 2.6.14
simonmaass commented 2 years ago

I just ran into the same issue

rikschennink commented 2 years ago

I'm currently working on a new version of FilePond and will also re-visit types.

smortexa commented 1 year ago

any news?

productdevbook commented 1 year ago

@rikschennink Thank you, Is there any news and it will be great if you support TS completely.

rikschennink commented 1 year ago

I'll be using JSDoc comments for v5, I believe that is compatible with TS