pqrs / l5b-crud

CRUD artisan command for rappasoft/laravel-5-boilerplate
21 stars 15 forks source link

Laravel 6 support #16

Open dividemysky opened 4 years ago

dividemysky commented 4 years ago

This branch enables support for the Laravel 6 version of boilerplate for both the frontend and backend scaffolds.

It also includes some typo fixes on various items (although it does not fix the typo from devanp's PR).

pqrs commented 4 years ago

Hi @dividemysky and thanks for your contribution. Excuse me I am very busy at the moment and have not time to test this. Could you please confirm everything works as expected? Also, if I merge your pull request, will it still work with 5.x or only with 6? I will merge it with your answer. Thank you!

dividemysky commented 4 years ago

No Problem! It looks like the change to BaseRepository in laravel-boilerplate is backwards breaking, so this PR only works with version 6 of Laravel Boilerplate.

dividemysky commented 4 years ago

I just implemented Events in my project and discovered a lingering bug; with the latest commit those should now work properly on the back & frontend as well.

julienfernandez commented 4 years ago

No news about that ?