search

pqrs / l5b-crud

CRUD artisan command for rappasoft/laravel-5-boilerplate
21 stars 15 forks source link

Few fixes + generation frontend files #8

Closed rabol closed 5 years ago

rabol commented 5 years ago

Hi

Fixes a 'bug' in the generation of Event, where a extra " (quote) was added Fixes a bug where $document is used in the Event class, but in the listener another property is used

New: Create separate label files for the backend New: with option --frontend: Create frontend files: Controller, Labels, Event, Request, Listener, view, route, Repository New: with option --force on can overwrite existing files

pqrs commented 5 years ago

Hi @rabol and thank you so much for this pull request! You have done an impressive work here. I have merged it although I had not the time to test it. I hope to have done it right because I ran into some issues while doing it.

Version 1.4 with all your updates is available now in packagist.

Thanks again. I'll try to test it myself tomorrow.

rabol commented 5 years ago

Hi

Thanks, let me know if you find any problems

Sent from my iPhone

On 2 Apr 2019, at 21:24, alvaro notifications@github.com wrote:

Hi @rabol and thank you so much for this pull request! You have done an impressive work here. I have merged it although I had not the time to test it. I hope to have done it right because I ran into some issues while doing it.

Version 1.4 with all your updates is available now in packagist.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

pqrs commented 5 years ago

Hi @rabol! Sorry I couldn't take a peek to this before, it's been a hard week here. I have just updated the README.md file to include latest changes. Please let me know if I forgot something.

I see you have replicated the backend behavior to the frontend. I just don't see if this is the best way of doing it, I mean, maybe it's better just leaving a very basic controller with no routes or views. Anyway, I'll leave it as you did, as it is an optional feature and maybe some other users come with another ideas.

Finally, I don't know if I did something wrong when merging your PR as you don't appear in the contributors list. Sorry about that, my knowledge of git/github is very basic.

rabol commented 5 years ago

No problem Yes the frontend is a copy of the backend. I was thinking to make a command for each type of generator but did not have the time.

I have just discovered a small issue in the backend bredcrumb stub

And for 5.8 the id ( increment) should be a bigIncrement

Sent from my iPhone

On 6 Apr 2019, at 14:06, alvaro notifications@github.com wrote:

Hi @rabol! Sorry I couldn't take a peek to this before, it's been a hard week here. I have just updated the README.md file to include latest changes. Please let me know if I forgot something.

I see you have replicated the backend behavior to the frontend. I just don't see if this is the best way of doing it, I mean, maybe it's better just leaving a very basic controller with no routes or views. Anyway, I'll leave it as you did, as it is an optional feature and maybe some other users come with another ideas.

Finally, I don't know if I did something wrong when merging your PR as you don't appear in the contributors list. Sorry about that, my knowledge of git/github is very basic.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.