Set default digit value for hotp.GenerateCodeCustom()

pquerna / otp

TOTP library for Go

Apache License 2.0

2.26k stars 222 forks source link

Set default digit value for hotp.GenerateCodeCustom() #77

Closed svbnbyrk closed 1 year ago

svbnbyrk commented 1 year ago

Problem: If the validateOps.Digit parameter is not passed to the hotp.GenerateCodeCustom() function, the default value is not correctly assigned. By default, it should generate a 6-digit code, but it produces 0.

Solution:

Add unit test for hotp.GenerateCodeCustom()
I set the otp.DigitSix value as the default.

svbnbyrk commented 1 year ago

Hi @pquerna , I'm attending Hactoberfest. This PR must have a hacktoberfest label to be valid for Hactoberfest participation rules. Can you add the hackoberfest label this PR pls?

svbnbyrk commented 1 year ago

Hi @pquerna, This PR isn't valid yet. I guess just hacktoberfest-accepted label is enough. My fault, sorry. Thank u for support.