pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
14 stars 15 forks source link

[WIP] Add time histories #104

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

Changes proposed in this pull request:

@pr-omethe-us/chemked

kyleniemeyer commented 6 years ago

Was this expected to fail (if still in progress), or no?

bryanwweber commented 6 years ago

It's a flake8 failure, so I'd say, yes because WIP, but not expected 😄

codecov[bot] commented 6 years ago

Codecov Report

Merging #104 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #104   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         878    951   +73     
  Branches      212    228   +16     
=====================================
+ Hits          878    951   +73
Impacted Files Coverage Δ
pyked/converters.py 100% <100%> (ø) :arrow_up:
pyked/validation.py 100% <100%> (ø) :arrow_up:
pyked/chemked.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 810da1c...f047fc7. Read the comment docs.

bryanwweber commented 6 years ago

Once the tests pass, this should be good to merge :+1: