Closed bryanwweber closed 6 years ago
Merging #109 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #109 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 4 +1
Lines 951 955 +4
Branches 228 227 -1
=====================================
+ Hits 951 955 +4
Impacted Files | Coverage Δ | |
---|---|---|
pyked/orcid.py | 100% <100%> (ø) |
|
pyked/validation.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d3053cf...138b9d5. Read the comment docs.
Do we need some tests for the new function?
No, it should all be covered by the existing test suite
CHANGELOG?
I'm good with this other than that change.
In #110
CHANGELOG.md
Changes proposed in this pull request:
@pr-omethe-us/chemked