pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
14 stars 15 forks source link

Fix ORCID API calls #109

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

Changes proposed in this pull request:

@pr-omethe-us/chemked

codecov[bot] commented 6 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      4    +1     
  Lines         951    955    +4     
  Branches      228    227    -1     
=====================================
+ Hits          951    955    +4
Impacted Files Coverage Δ
pyked/orcid.py 100% <100%> (ø)
pyked/validation.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3053cf...138b9d5. Read the comment docs.

kyleniemeyer commented 6 years ago

Do we need some tests for the new function?

bryanwweber commented 6 years ago

No, it should all be covered by the existing test suite

kyleniemeyer commented 6 years ago

CHANGELOG?

kyleniemeyer commented 6 years ago

I'm good with this other than that change.

bryanwweber commented 6 years ago

In #110