pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
15 stars 15 forks source link

Get a DataFrame as output #16

Closed bryanwweber closed 8 years ago

bryanwweber commented 8 years ago

Adds a method to ChemKED to get a Pandas DataFrame as output. Only imports pandas if this method is called, so pandas is not required to run the whole package. Adds tests that should skip if pandas is not found.

Tests are currently failing because of a server issue at CrossRef: https://github.com/CrossRef/rest-api-doc/issues/147

codecov-io commented 8 years ago

Current coverage is 91.15% (diff: 100%)

Merging #16 into master will increase coverage by 7.15%

@@             master        #16   diff @@
==========================================
  Files             5          5          
  Lines           175        226    +51   
  Methods           0          0          
  Messages          0          0          
  Branches         40         63    +23   
==========================================
+ Hits            147        206    +59   
+ Misses           18         11     -7   
+ Partials         10          9     -1   

Powered by Codecov. Last update 12c273c...f7b8916

bryanwweber commented 8 years ago

I also forgot I was supposed to look at @staticmethods etc. I think that deserves a different PR.

kyleniemeyer commented 8 years ago

I made a few minor comments, but otherwise I think it looks good.