search

pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
15 stars 15 forks source link

Add more tests #47

Closed bryanwweber closed 7 years ago

bryanwweber commented 7 years ago

Changes proposed in this pull request:

@pr-omethe-us/chemked

codecov-io commented 7 years ago

Codecov Report

Merging #47 into master will increase coverage by 5.6%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #47     +/-   ##
=======================================
+ Coverage   94.39%   100%   +5.6%     
=======================================
  Files           5      5             
  Lines         339    355     +16     
  Branches       94     98      +4     
=======================================
+ Hits          320    355     +35     
+ Misses         11      0     -11     
+ Partials        8      0      -8
Impacted Files Coverage Δ
pyked/chemked.py 100% <100%> (+5.58%) :arrow_up:
pyked/validation.py 100% <100%> (+6.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 898e43a...a8b1de9. Read the comment docs.

kyleniemeyer commented 7 years ago

The only "downside" to this PR, is that we will have to work very hard to ensure all future changes don't reduce coverage... the challenges of perfection.