search

pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
15 stars 15 forks source link

Split schema yaml #52

Closed bryanwweber closed 7 years ago

bryanwweber commented 7 years ago

Changes proposed in this pull request:

I added a custom directive in the chemked_schema.yaml file called !include. This directive should only be allowed in the schema files, never in the data files (IMO). It is implemented as a simple string cat of the included files into the main schema, replacing the !include line with the contents of the appropriate file. In this way, it should be cross-language (i.e., can be implemented in other languages where we want to validate ChemKED files).

@pr-omethe-us/chemked

codecov[bot] commented 7 years ago

Codecov Report

Merging #52 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #52   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         354    372   +18     
  Branches       99    101    +2     
=====================================
+ Hits          354    372   +18
Impacted Files Coverage Δ
pyked/validation.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2c5f53...5cb0a3e. Read the comment docs.