Should common-properties be automatically filled into a datapoint element if unspecified?

pr-omethe-us / PyKED

Python interface to the ChemKED database format

https://pr-omethe-us.github.io/PyKED/

BSD 3-Clause "New" or "Revised" License

15 stars 15 forks source link

Should common-properties be automatically filled into a datapoint element if unspecified? #59

Closed bryanwweber closed 7 years ago

bryanwweber commented 7 years ago

PyKED/ChemKED version

v0.1.5

Title question raised by Mike Burke's group at Columbia

bryanwweber commented 7 years ago

In my opinion, explicit is better than implicit, so I think it should be specified in each datapoint element. This also avoids the case where the user forgets that the temperature is different for one or a few cases, and the wrong value gets included from common properties. Other thoughts?

kyleniemeyer commented 7 years ago

I agree. This sort of thing might seem like a timesaver when writing files manually, but that isn't the eventual goal anyways, and I think the potential negatives outweigh the (minor) benefits.