pr-omethe-us / PyKED

Python interface to the ChemKED database format

https://pr-omethe-us.github.io/PyKED/

BSD 3-Clause "New" or "Revised" License

15 stars 15 forks source link

Add noarch #74

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

[x] Added entry into CHANGELOG.md

Changes proposed in this pull request:

Switch the conda package to a noarch package, meaning it runs on any version of Python that we indicate is compatible in the recipe (i.e., >=3.5)
Require Python compatible with 3.5 for pip installs
Remove universal designation for wheels which wasn't appropriate anymore anyways

@pr-omethe-us/chemked

bryanwweber commented 6 years ago

@kyleniemeyer This seems good to merge, but after you merge, let's wait to make a release of a new version. I think there are going to be some updates from the IJCK article, and we can make a release to coincide with submitting the response.

codecov[bot] commented 6 years ago

Codecov Report

Merging #74 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         851    851           
  Branches      202    202           
=====================================
  Hits          851    851

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 535e74e...416b2a2. Read the comment docs.

kyleniemeyer commented 6 years ago

Nice! Yeah looks good to merge, and I agree on waiting for a new version.