search

pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
15 stars 15 forks source link

Appveyor cov #75

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

Changes proposed in this pull request:

@pr-omethe-us/chemked

bryanwweber commented 6 years ago

So it saved about 30 seconds on Linux to combine the Travis runs. I think the main benefit is that only one macOS job has to run, which means less waiting in the queue (hopefully), but as we add more tests, the benefit is going to drop... Thoughts?

codecov[bot] commented 6 years ago

Codecov Report

Merging #75 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #75   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         851    851           
  Branches      202    202           
=====================================
  Hits          851    851

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e99096a...fba65e8. Read the comment docs.

kyleniemeyer commented 6 years ago

I guess it doesn't seem that big of a deal, but streamlines things a little bit

bryanwweber commented 6 years ago

The test failures here will be resolved when #77 is merged