search

pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
14 stars 15 forks source link

Polite crossref #92

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

Changes proposed in this pull request:

@pr-omethe-us/chemked

codecov[bot] commented 6 years ago

Codecov Report

Merging #92 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #92   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         872    874    +2     
  Branches      208    208           
=====================================
+ Hits          872    874    +2
Impacted Files Coverage Δ
pyked/validation.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1ec5b5...070dbf8. Read the comment docs.

kyleniemeyer commented 6 years ago

What enables us to remove the UnboundLocalError?

bryanwweber commented 6 years ago

He merged your PR several releases ago into Habanero: https://github.com/sckott/habanero/pull/43#issuecomment-241580446

kyleniemeyer commented 6 years ago

I had totally forgotten about doing that... 😩