pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
14 stars 15 forks source link

File author -> File authors #95

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

Changes proposed in this pull request:

Changes contributed by @kypore1 aka @EthanBesse

@pr-omethe-us/chemked

codecov[bot] commented 6 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.22%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage     100%   99.77%   -0.23%     
==========================================
  Files           5        5              
  Lines         873      875       +2     
  Branches      208      209       +1     
==========================================
  Hits          873      873              
- Partials        0        2       +2
Impacted Files Coverage Δ
pyked/chemked.py 100% <100%> (ø) :arrow_up:
pyked/converters.py 99.37% <75%> (-0.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9942fbd...651e97c. Read the comment docs.

kyleniemeyer commented 6 years ago

We're missing some coverage converters.py!

bryanwweber commented 6 years ago

I've got it covered in a PR that requires this one 😸 yuk yuk yuk workin on those dad jokes

kyleniemeyer commented 6 years ago

Hah, ok

kyleniemeyer commented 6 years ago

Wow, interestingly, “Pulk requests that have a failing status can’t be merged on a phone.”

I tried.

bryanwweber commented 6 years ago

Bogus! Well, I can merge when I get a chance, or you can take care of it if I don't get it 😁