pr-omethe-us / PyKED

Python interface to the ChemKED database format
https://pr-omethe-us.github.io/PyKED/
BSD 3-Clause "New" or "Revised" License
14 stars 15 forks source link

Habanero mailto + other fixes #97

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

Changes proposed in this pull request:

@pr-omethe-us/chemked

codecov[bot] commented 6 years ago

Codecov Report

Merging #97 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      4    -1     
  Lines         883    879    -4     
  Branches      210    212    +2     
=====================================
- Hits          883    879    -4
Impacted Files Coverage Δ
pyked/chemked.py 100% <100%> (ø) :arrow_up:
pyked/converters.py 100% <100%> (ø) :arrow_up:
pyked/validation.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7953f0a...107dc2b. Read the comment docs.

kyleniemeyer commented 6 years ago

Is the loss of coverage here also made up in another PR?

bryanwweber commented 6 years ago

Yes, the @codecov comment should be updated now with 100% coverage. Actually, the reason was because I originally didn't include those changes to bring it back to 100% in this changeset (because they were already in #96), but now its been rebased on the new master after merging #96 so all should be well.