search

pr-omethe-us / pyked-papers

Various papers published about PyKED
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

IJCK R1C11 #15

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

p. 8 "In the latter case, some information may be lost, as ChemKED files both encode more details and specify more granularity of some information than ReSpecTh files." This was true for ReSpecTh format 1.0, but no longer true for ReSpecTh Kinetic Dataformat 2.0. The latter covers all info of the ChemKED files (and more).

bryanwweber commented 6 years ago

Ref: https://github.com/pr-omethe-us/pyked-papers/issues/2#issuecomment-332325822

From Kyle:

We'll have to look at v2.0 of their format and update. However, a quick look shows that their bibliographyLink still doesn't include granular details about a reference, just DOI and "description". I'm not sure if we were referring to more than that, though.

bryanwweber commented 6 years ago

With this comment, we're actually referring to ChemKED->ReSpecTh, so the bibliographyLink is sort of irrelevant (we can just take our data and shove it into the unformatted string they use). However, I think the comment is still technically true because RST doesn't support mass fractions as an initial composition option.

I did change the sentence slightly though, to try to appease the reviewer.

kyleniemeyer commented 6 years ago

Sounds good. I just added a "currently" for the ReSpecTh -> ChemKED, as we do plan to extend to the experiment types they support.