search

pr-omethe-us / pyked-papers

Various papers published about PyKED
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

IJCK R2C3 #20

Closed bryanwweber closed 6 years ago

bryanwweber commented 6 years ago

I think the article would be more appealing if it would have at least one figure as an example.

bryanwweber commented 6 years ago

Ref: https://github.com/pr-omethe-us/pyked-papers/issues/3#issuecomment-332316621

From Kyle:

Any ideas for a figure? I agree that it would be nice to have one, though we do have a lot of code snippets and such. Maybe we could add plotting of calculated ignition delays to the example at the end, and actually show such a figure? Or, we could include some sort of workflow diagram? The first half of the paper is probably what needs one the most, just to break up text, but I don't have any good ideas.

bryanwweber commented 6 years ago

I think a workflow diagram would be good. Another idea is a visualization of the sections of the ChemKED file, and/or a visualization of the structure of PyKED/ChemKED class

kyleniemeyer commented 6 years ago

Now that we have three figures thanks to the examples, I think we're good on this one.