pr-omethe-us / pyked-papers

Various papers published about PyKED
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

IJCK #2 R2C3 #48

Closed kyleniemeyer closed 6 years ago

kyleniemeyer commented 6 years ago

p. 9 “If the volume-history of an RCM experiment is provided in the ChemKED file, it is stored in this attribute as a namedtuple ,” Question: Is this format able to handle the case when a shock tube measurement is accompanied with a pressure history?

kyleniemeyer commented 6 years ago

We currently support a constant preignition pressure rise, but not an actual pressure history—but it would be quite simple to extend to this. I can probably tackle that fairly easily.

@bryanwweber any opposition?

bryanwweber commented 6 years ago

I would suggest referring to our changes to the time-histories field in https://github.com/pr-omethe-us/PyKED/issues/91

kyleniemeyer commented 6 years ago

ah, crap. I guess we need to update the text to reflect those changes.

bryanwweber commented 6 years ago

Well, those changes haven't been made yet, so maybe just a footnote would be good.

kyleniemeyer commented 6 years ago

This is the discussion I am adding to the response:

The current version of ChemKED can represent a constant preignition pressure rise in shock tubes through the \yabox|pressure-rise| key. It does not currently support specifying a pressure time-history, although we are planning to extend support for more time histories for both shock tubes and rapid compression machines in a future version (for, e.g., pressure, volume, piston position, light emission, OH emission, and absorption). See \url{https://github.com/pr-omethe-us/PyKED/issues/91} for our discussion on these plans.

kyleniemeyer commented 6 years ago

And I added a footnote to page 7:

Future versions of ChemKED will support specifying additional time histories for rapid compression machine and shock tubes (e.g.,pressure, volume, light emission, OH emission). These will follow the specification format given for volume.