search

pr0gramista / charset_converter

Flutter platform charset converter
BSD 3-Clause "New" or "Revised" License
33 stars 22 forks source link

Linux support added #18

Closed bojidartonchev closed 9 months ago

bojidartonchev commented 2 years ago

Linux support added using iconv library,

pr0gramista commented 2 years ago

Thank you so much for your time and effort! 💙

I'll review, test and release a new version as soon as possible. I expect to have it published by the end of the next week. Hopefully sooner. Thanks!

pr0gramista commented 2 years ago

Hey, I've tested the changes and some things don't seem right.

Encoding is crashing the app. I wasn't able to encode even to utf-8. Decoding seems to be working at least partially. I think the problem might be in the assumption that the length of the input is gonna be equal to the length of output buffer linux/charset_converter_plugin.cc:116 which does not work. Checking availability looks fine. Getting a list of supported encoding is probably gonna be manual work as the Windows support - I can do that.

Please check it yourself and let me know if the problem is related to my quick setup. I was using Ubuntu 20.04 LTS to test this. Unfortunately, all integration tests fail, but that might be a problem in Flutter itself so that's OK.

Thanks 💙

pr0gramista commented 9 months ago

Closing in favor of https://github.com/pr0gramista/charset_converter/pull/38

Though I feel so sorry for not taking action on this 🤐