search

pr0gramista / charset_converter

Flutter platform charset converter
BSD 3-Clause "New" or "Revised" License
29 stars 22 forks source link

Missing import #32

Open rkdermalog opened 11 months ago

rkdermalog commented 11 months ago

Hello,

with this commit: 13adf8e198c2a6484cb39c7b3cea31a75634c042 u had remove the import of 'dart:typed_data'. This import is needed for Uint8list so i cant build projects with the last release.

pr0gramista commented 10 months ago

Hey, sorry for the late response. I just checked the example and it seems to run fine on Flutter 3.16.3 after upgrading icons (gonna fix it in a minute). Could you provide more details or an example? It would be super helpful.

The reason the import was removed is that package:flutter/services.dart already imports Uint8List and since this is a Flutter plugin it should be always available 🤔

Thanks!

rkdermalog commented 10 months ago

Hello, sorry for my late answer. If u use a new flutter version with dart-sdk > 3.0.0 then u are right, package:flutter/services.dart had this import already. But if u use a flutter version like 3.0.1 with dart-sdk < 3.0.0 then the import is missing. The problem is your pubsepc.yaml

environment: sdk: ">=2.12.0 <3.0.0" flutter: ">=1.17.0"

sdk: must be ">=3.0.0" so flutter pub get will not update your plugin with lower dart versions, because remove this import is a breaking api change in my opinion.

Another problem is that the max constraint is ignored by flutter pub get, see this issue: https://github.com/flutter/flutter/issues/95472#issuecomment-1119312969

Sorry for my horrible english. I create a simple example project for u, flutter fvm u can simple test with different flutter versions.

if any questions pls ask :)

charset_example.zip

junglesub commented 2 months ago

I encountered the same issue while working with my legacy application. It seems to function correctly with Dart SDK versions greater than 3.0.0. However, it would be great if we could also maintain support for older versions to accommodate legacy systems. Thanks!