pr0gramista / charset_converter

Flutter platform charset converter
BSD 3-Clause "New" or "Revised" License
29 stars 19 forks source link

Add namespace to fix issue with build appbundle #36

Closed MemphisNguyen closed 8 months ago

MemphisNguyen commented 8 months ago

On running appbundle build, I got below error

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':charset_converter'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

Adding the missing namespace to bypass the error

nowfalsalahudeen commented 8 months ago

Please merge it asap

pr0gramista commented 8 months ago

@MemphisNguyen thank you very much for this contribution 💙 I'll release a new version in a few minutes.

And thanks @nowfalsalahudeen for the reminder - I must have missed the notification during the holidays 🙄

pr0gramista commented 8 months ago

Released as 2.1.2

nowfalsalahudeen commented 8 months ago

Thanks for make it quick

nowfalsalahudeen commented 8 months ago

there is one more issue in latest version. please upgrade it, i cant downgrade to 1.8, some other libs targeting newer version

pr0gramista commented 8 months ago

I see... let me upgrade my Android SDK and I'll check it out