search

pr0v3rbs / FirmAE

Towards Large-Scale Emulation of IoT Firmware for Dynamic Analysis
MIT License
642 stars 119 forks source link

fix sleep command not found error #4

Closed newthis closed 3 years ago

newthis commented 3 years ago

not all firmware fs have sleep command

pr0v3rbs commented 3 years ago

Thank you for your PR!

We noticed that the sleep binary does not exist in the filesystem of some Netgear and TP-Link firmware images. In those cases, the sleep command needs to be supported by using a custom busybox, and some more codes need to be fixed like your commit.

However, can you share the case to improve the knowledge base?

newthis commented 3 years ago

It dependes on the device and firmware vendor, for example: https://www.tp-link.com/us/home-networking/wifi-router/tl-wr740n/.

pr0v3rbs commented 3 years ago

Thank you for sharing the information.

We checked some TP-Link firmware successfully emulated by adding sleep command (Detail description will be added before the merging).

However we need to check whether exist the side-effect on the other data-set (I think will none).