pr0v3rbs / FirmAE

Towards Large-Scale Emulation of IoT Firmware for Dynamic Analysis
MIT License
603 stars 117 forks source link

Please check my install.sh version; error catching #51

Open n0s3y opened 1 year ago

n0s3y commented 1 year ago

Please take a look at my install.sh version considering the error handling.

m-1-k-3 commented 1 year ago

Nice work! I would recommend using a different demo firmware. This one only gets reachable via ICMP. There are plenty of others with web and/or other services available.

n0s3y commented 1 year ago

Will do! Thanks for the feedback.

On Thu, Oct 20, 2022, 13:43 Michael Messner @.***> wrote:

Nice work! I would recommend using a different demo firmware. This one only gets reachable via ICMP. There are plenty of others with web and/or other services available.

— Reply to this email directly, view it on GitHub https://github.com/pr0v3rbs/FirmAE/pull/51#issuecomment-1285384204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZGUHM3QQNCV5QQNXB5MCKLWEEV7XANCNFSM6AAAAAAQ3AMAZQ . You are receiving this because you authored the thread.Message ID: @.***>

pr0v3rbs commented 1 year ago

Sorry for the late and thank you for your hard work and passion. Also, I appreciate all comments.

However, the Pull Request was updated many times. So, I wonder if this Pull Request was finished.

Is this the final commit state for this Pull Request?

n0s3y commented 1 year ago

Dear Mingeun,

The latest version on my FirmAE clone is the correct version. Sorry for the many commits. I wanted to perfect this repo for my students

On Sun, Oct 30, 2022, 13:43 Mingeun Kim @.***> wrote:

Sorry for the late and thank you for your hard work and passion. Also, I appreciate all comments.

However, the Pull Request was updated many times. So, I wonder if this Pull Request was finished.

Is this the final commit state for this Pull Request?

— Reply to this email directly, view it on GitHub https://github.com/pr0v3rbs/FirmAE/pull/51#issuecomment-1296249431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZGUHMZQ7FBVZKH7BWSRCDLWFZUOLANCNFSM6AAAAAAQ3AMAZQ . You are receiving this because you authored the thread.Message ID: @.***>

n0s3y commented 1 year ago

Yes this is the final commit state!