pr3y / Bruce

Predatory ESP32 Firmware
https://bruce.computer
GNU Affero General Public License v3.0
598 stars 89 forks source link

inverted IR led option #219

Open eadmaster opened 2 months ago

eadmaster commented 2 months ago

i am not sure if these lines are correct:

https://github.com/pr3y/Bruce/blob/main/src/modules/ir/TV-B-Gone.cpp#L539 https://github.com/pr3y/Bruce/blob/main/src/modules/ir/TV-B-Gone.cpp#L551

the true arg will set the inverted mode:

https://github.com/crankyoldgit/IRremoteESP8266/blob/a5c6902816fcacefc540a5339922c4626da30515/src/IRsend.h#L246

In my tests these actually worked in both modes, but in the end i guess this should be a module setting and not hardcoded (Some IR modules may have inverted logic, some don't).

geo-tp commented 2 months ago

Isn't this the toggle bit used by the RC5/RC6 protocols? Some Philips devices use this, for example to turn up the volume, each press will send a command with the last bit changing.

I don't use the same version of the IRemote lib but in the version I use, it's like this

rc5