search

pr4aveen / pe

0 stars 0 forks source link

Error when editing causes runtime exception. App does not crash #2

Open pr4aveen opened 4 years ago

pr4aveen commented 4 years ago

Refer to the below image

Screenshot 2020-11-13 at 4.30.59 PM.png

I ran edit 2 ans/-1 on your sample data. This should give me an error right?

There is however no indication in the UI that I entered an invalid command. There's also a runtime exception displayed in terminal.

nus-pe-bot commented 4 years ago

Team's Response

It is our bad that we do not check for negative answer when creating the editedFlashcard just like the addmcq command. Thank you for the bug report!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I think that the severity should stay as Medium for the following reasons:

  1. Unhandled exception

  2. Application shows no indication of an error

    1. User will not know that something is wrong as there is no error message and red text when an incorrect command is run
    2. If the user finds out that the command didn't work, he/she won't know why

  3. Product can still be used, but this will be an occasional inconvenience as it might take the user a while to find out what's wrong (input constraints for the edit command are not mentioned in the UG)

  4. The issue matches 2 out of the 3 criteria (numbers 2 and 3) for a functionality bug

    1. image.png

For these reasons, I think giving this issue a medium severity is justified.