search

pr8x / DesktopNotifications

A cross-platform C# library for native desktop "toast" notifications.
MIT License
177 stars 29 forks source link

Update to av11 #23

Closed alexalok closed 12 months ago

alexalok commented 1 year ago

Hi!

Thank you for your library, I find it really useful. Since I am using Avalonia 11 I took it upon myself to try and port your library to it. I am quite new to Avalonia so there might be something left to improve. I am open for amendments.

EtherGhost commented 12 months ago

Tragic to see how project like this gets abandoned...

pr8x commented 12 months ago

@EtherGhost I would love to merge the PR if OP responds to my review.

alexalok commented 12 months ago

Hey @pr8x, is there anything I should do on my side? Thanks.

pr8x commented 12 months ago

@alexalok I left some comment here: https://github.com/pr8x/DesktopNotifications/pull/23#discussion_r1279370172

EtherGhost commented 12 months ago

@EtherGhost I would love to merge the PR if OP responds to my review.

Ok, my bad! Sorry!

alexalok commented 12 months ago

@pr8x I can't see this comment for some reason. Perhaps you could re-review or post a comment separately?

pr8x commented 12 months ago

@alexalok Seems that I did not submit the review on GitHub. Sorry for the inconvenience. It was only a NIT anyways. Approved the PR & thanks for contributing!

pr8x commented 12 months ago

@alexalok Now that AvaloniaLocator is removed I am not even sure if we need the DesktopNotifications.Avalonia package at all. Users can easily create the notification manager without going through the AppBuilder... and it would probably be better since AppBuilder is not async anyways. What do you think? Of course, we can keep the Example code showcasing the notification manager in an Avalonia application.

alexalok commented 11 months ago

@pr8x, sorry for the delayed response. I think the package could still be beneficial due to AppBuilderExtensions.SetupDesktopNotifications method. It can also help being more explicit in that the library supports Avalonia.