search

prabaprakash / Saavn-Downloader

Saavn Downloader
92 stars 41 forks source link

Problem with downloading songs whose titles have : in them #24

Closed ar7x9 closed 5 years ago

ar7x9 commented 5 years ago

URL in question : https://www.jiosaavn.com/album/gunday/rFL,r8r-O7A_

What happens is that the song is shown as downloaded on the terminal, but in actual there is an undeletable file thats created on my hdd with name "Gunday (Rap By" with no extension and 0 KB size, i.e. a corrupted file.

inovachrono commented 5 years ago

May be this will be helpful https://stackoverflow.com/questions/1976007/what-characters-are-forbidden-in-windows-and-linux-directory-names

ar7x9 commented 5 years ago

I just went over the code, let me see if I can find a fix. I am gonna add a few lines after line 141 to check and replace those illegal characters.

Edit:

I managed to fix it. Add these lines to Download.py after line 141

filename = filename.replace(":", "-") filename = filename.replace("<", "-") filename = filename.replace(">", "-") filename = filename.replace("?", "-") filename = filename.replace("*", "-") filename = filename.replace("|", "-")