Open jnachtigall opened 1 year ago
@jnachtigall Thanks for reporting the issue. can you share the repo details where this issue can be reproduced.
No, the repo is private. But it is easy to reproduce:
npm install ../react-chrono/
@jnachtigall
These last lines should be deleted and only peerDependencies used.
devDependencies
cannot be modified as react
and react-dom
are important dependencies for development.
Are you trying to contribute back to the project or you want to customize and use it back in your project. If its for the later reason, then its ideal to make changes on the main repo first.
Describe the bug I use the library locally so I can make a few changes. This way I hit this error: https://stackoverflow.com/questions/56021112/react-hooks-in-react-library-giving-invalid-hook-call-error/57422196
The
package.json
has https://github.com/prabhuignoto/react-chrono/blob/9c7bc09b71bbc4935a0d3eb703bb066e192b74f0/package.json#L39-L41 and the rollup config has https://github.com/prabhuignoto/react-chrono/blob/9c7bc09b71bbc4935a0d3eb703bb066e192b74f0/rollup.config.mjs#L54The problem is that the
package.json
also has these dependencies too: https://github.com/prabhuignoto/react-chrono/blob/9c7bc09b71bbc4935a0d3eb703bb066e192b74f0/package.json#L94-L95These last lines should be deleted and only peerDependencies used.
BTW: There is also https://github.com/prabhuignoto/react-chrono/blob/9c7bc09b71bbc4935a0d3eb703bb066e192b74f0/package.json#L96
But
react-is
does not seem to be used anywhere.