use feedkeys(xxx, 'ni'), fix #1345 - Githubissues

prabirshrestha / vim-lsp

async language server protocol plugin for vim and neovim

MIT License

3.1k stars 304 forks source link

use feedkeys(xxx, 'ni'), fix #1345 #1493

Closed ZSaberLv0 closed 10 months ago

prabirshrestha commented 11 months ago

@ZSaberLv0 can you rebase to latest master and fix the merge conflicts?

ZSaberLv0 commented 11 months ago

@ZSaberLv0 can you rebase to latest master and fix the merge conflicts?

@prabirshrestha merged

prabirshrestha commented 11 months ago

Have you also tried https://github.com/prabirshrestha/vim-lsp/pull/1429. Seems a bit similar

ZSaberLv0 commented 11 months ago

Have you also tried #1429. Seems a bit similar

it also solves the issue, by a different logic:

use feedkeys(xxx, 'ni') : insert keys instead of append, process s:on_complete_done_after before other plugins
- this may also cause issue if other plugins also used feedkeys(xxx, 'ni') and called before vim-lsp
use #1429 : wait until other plugin's done, and conditionally call s:on_complete_done_after by checking mode() state changes
- this may (or may not) cause s:on_complete_done_after won't be called

prabirshrestha commented 10 months ago

Merged. Thanks!

prabirshrestha commented 10 months ago

Had to revert the PR. didn't work with https://github.com/cohama/lexima.vim.