search

prabirshrestha / vim-lsp

async language server protocol plugin for vim and neovim
MIT License
3.12k stars 305 forks source link

Add missing borders to Neovim's floating windows #1565

Closed Jorenar closed 2 months ago

Jorenar commented 3 months ago

Related to issue #1207

In Vim, when e.g. peeking at type definition, the popup windows have a border drawn around them: screenshot-20240709_222924

While in Neovim such border is missing: screenshot-20240709_223010

With the small fix from this PR: screenshot-20240709_223146

The readability is quite improved.

prabirshrestha commented 2 months ago

I already seem to be having border in Neovim.

image

Jorenar commented 2 months ago

@prabirshrestha Oh right, I forgot to mention that :LspHover do have a border and it is indeed the same single line in both Vim and Neovim. The other popup windows (like e.g. for :LspTypeDefinition) have double line border in Vim, and no border in Neovim.

Jorenar commented 2 months ago

@prabirshrestha ?

prabirshrestha commented 2 months ago

Merged. Thanks!