search

prabushitha / gremlin-visualizer

visualize the graph network corresponding to a gremlin query
MIT License
227 stars 73 forks source link

adding a gremlin REST option. Sending better error messages. npm audit #4

Closed thiagomata closed 3 years ago

thiagomata commented 4 years ago

In the last version of the gremlin server, there are some problems using the WebSocket version. So, this branch uses the REST API to provide a similar experience. Also, it provides better data handling with the error messages when the query fails and add some logs to help to see what is happening.

The current version was tested with Gremlin 3.2.5 using the docker https://hub.docker.com/r/bricaud/gremlin-server-with-demo-graph/. image

cscetbon commented 4 years ago

@thiagomata you sure those changes work with AWS Neptune ? Other than that, I think those changes are great

cscetbon commented 4 years ago

I also don't see a way to enable debug logs in the current version, but yours seems to add that feature too. Can you confirm it ?

thiagomata commented 4 years ago

Yes. I added some very basic logging when getting error messages.

thiagomata commented 4 years ago

@thiagomata you sure those changes work with AWS Neptune ? Other than that, I think those changes are great

Yes, I was using for that. But you have to set the REST_SERVER to true.

triggan commented 3 years ago

One change that needs to be made before this PR is committed - Neptune specifically defaults to TLS/SSL only connectivity as of Feb. of 2020. Moreover, as of Neptune version 1.0.4.0 released in Oct. 2020, non-TLS traffic is no longer permitted. As such, the use of ws:// needs to be changed to wss:// or there needs to be some sort of flag to set the use of TLS or non-TLS for other TinkerPop compatible databases as well.