codepathreview
commented
10 years ago :+1: Excellent work Prachi. A few notes after checking out the code:
- Good use of margins, sp/dp in view and relative placement rules
- Good layout, proper view naming
- Good use of string resources for text values.
- Good job using the ViewHolder Pattern
- Great job implementing SwipeRefreshLayout.
- Good job implementing your JSON deserializing logic in your InstagramPhoto class.
- Great job with the RoundedTransformationBuilder() for User photo
- Great use of using the DateUtils.getRelativeTimeSpanString
- Very good job of displaying 2 latest comments
- Great job on polishing your UI to make it look like the real instagram app
- Keep playing more with layout to align the widgets more neatly
- Consider initializing your objects only once (listview, adapters, etc) during onCreate() instead of fetchPopularPhotos();
One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.
We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.
Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.
If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@thecodepath.com.
P.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!
My app is complete, could you please review it? /cc @nesquena @thecodepath
Thanks, Prachi