search

prachtsaal / prachtsaal.berlin

The website of Prachtsaal Studios
1 stars 0 forks source link

create event for art market #53

Closed mingness closed 1 month ago

mingness commented 1 month ago

Created as an event, but not a news item. Website still needs work in order to add news items to front page.

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-09-16 10:30 UTC

mingness commented 1 month ago

@hamoid yeah, the pr preview doesn't work fully, because the jekyll compiles it relative to the url in the config.

hamoid commented 1 month ago

I think there's a html tag that could help... something like "base". Not sure if it can be useful...

hamoid commented 1 month ago

The idea would be to add https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base on that preview, but can one add such tag conditionally?

hamoid commented 1 month ago

custom-url: Base URL to use when providing a link to the preview site.

Default: Will attempt to calculate the repository's GitHub Pages URL (e.g. "rossjrw.github.io").

(from the preview action docs)

hamoid commented 1 month ago

https://github.com/rossjrw/pr-preview-action/issues/14

mingness commented 1 month ago

I'm working on it. I think the solution is to set the baseurl in the jekyll build to the right route, which is pr-preview/pr-. I just need to figure out how to get the pr number

mingness commented 1 month ago

Hmm, still not working. @hamoid any other ideas?