practable / bookjs

Javascript booking client for timdrysdale/relay
GNU Affero General Public License v3.0
1 stars 1 forks source link

Remove fake bearer token from mutations.js #7

Closed timdrysdale closed 1 year ago

timdrysdale commented 2 years ago

There is a fake bearer token in the mutations.js which triggers an alert when pushing new commits to the repo. From memory, this was due to an error attempting to parse an empty string. It would be better to avoid the appearance of having secrets in the code-base, so that if any are accidentally included by a developer in future, it is less likely to be overlooked. (It's hard to manually parse the minified js that is dumped to screen when you commit a secret, which occurs when you have a secret scanner in your git hooks, leave a secret in the code, and push the distributed code to a repo that maintains current contents of servers).

timdrysdale commented 1 year ago

no longer relevant to the new code with xstate and the new API