practicajs / practica

Node.js solution starter boilerplate that is production-ready, packed with ✅ best practices and built with simplicity in mind
https://practica.dev/
MIT License
1.5k stars 136 forks source link

Fix #304 #305

Open hempun10 opened 1 year ago

hempun10 commented 1 year ago

Making the width of iframe 100% fix this issue:

Before: image

After:

image
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (a204201) 90.92% compared to head (3cd9f86) 90.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #305 +/- ## ======================================= Coverage 90.92% 90.92% ======================================= Files 16 16 Lines 595 595 Branches 43 43 ======================================= Hits 541 541 Misses 53 53 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/practicajs/practica/pull/305/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=practicajs) | Coverage Δ | | |---|---|---| | [app](https://app.codecov.io/gh/practicajs/practica/pull/305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=practicajs) | `91.97% <ø> (ø)` | | | [generator](https://app.codecov.io/gh/practicajs/practica/pull/305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=practicajs) | `63.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=practicajs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.