Fix dependencies and include GitHub action - Githubissues

practical-recommender-systems / moviegeek

A django website used in the book Practical Recommender Systems to illustrate how recommender algorithms can be implemented.

MIT License

901 stars 360 forks source link

Fix dependencies and include GitHub action #53

Open lazarofl opened 2 years ago

lazarofl commented 2 years ago

Dependency installation step was failing due to a conflict between urllib and botocore.

This PR aims to:

fix dependency conflict by downgrading urllib
include psycopg2-binary and nltk
add github action to avoid integrating broken code into master

Evidence of failure

docker-compose build web

#10 110.1 ERROR: Cannot install -r requirements.txt (line 4) and urllib3==1.26.5 because these package versions have conflicting dependencies.
#10 110.1
#10 110.1 The conflict is caused by:
#10 110.1     The user requested urllib3==1.26.5
#10 110.1     botocore 1.12.45 depends on urllib3<1.25 and >=1.20; python_version >= "3.4"

Reference PR

https://github.com/lazarofl/moviegeek/pull/2 action checks: https://github.com/lazarofl/moviegeek/pull/2/checks