Closed junghan0611 closed 1 year ago
Updating the images for the book is not as straight forward as changing the URL prefix. The new format for images is being used throughout the book as it is more reliable.
Also many of the images are being recreated with light and dark variants to work well with both book themes.
Such a large change should have been first raised as an issue, as mentioned in the contributing guide. Even without the above issues, it is unlikely such a large change would be accepted.
Thank you.
change rules 1) live/spacemacs -> live/editors/spacemacs 2) images -> https://raw.githubusercontent.com/practicalli/graphic-design/live/editors/spacemacs/screenshots
Please follow these guidelines when submitting a pull request
#
followed by the issue number (or paste full link to the issue)Submitting articles
Create an issue using the article template, providing as much detail as possible.
Website design
Suggestions about website design changes are most welcome, especially in terms of usability and accessibility.
Please raise an issue so we can discuss changes first, especially changes related to aesthetics.
Review process
All pull requests are reviewed by @practicalli-john and feedback provided, usually the same day but please be patient.