search

practicalmeteor / meteor-mocha

Depreciated - Write meteor package tests with mocha and run them in the browser or from the command line with spacejam.
https://atmospherejs.com/practicalmeteor/mocha
Other
41 stars 13 forks source link

embedded chai is out of date #66

Open laurentpayot opened 8 years ago

laurentpayot commented 8 years ago

From the version file I can see that embedded chai version is 2.1.0_1. Current chai library on npm is 3.5.0. The old one used by meteor-mocha misses quite useful assertions such as chai.assert.isAtLeast or chai.assert.isAtMost and more, so I have to import chai via npm anyway. It could be the time for an update…

PS: I love meteor-mocha. Wish it was on npm...

rhettlivingston commented 8 years ago

Or it could be the time to remove embedded chai now that it works nicely from npm. I stopped using it months ago and have seen no issue with using the npm package directly.

On Thu, Aug 18, 2016 at 3:35 AM, Laurent Payot notifications@github.com wrote:

From the version file I can see that embedded chai version is 2.1.0_1. Current chai library on npm is 3.5.0. The old one used by meteor-mocha misses quite useful assertions such as chai.assert.isAtLeast or chai.assert.isAtMost and more, so I have to import chai via npm anyway. It could be the time for an update…

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/practicalmeteor/meteor-mocha/issues/66, or mute the thread https://github.com/notifications/unsubscribe-auth/AH5TYhw1Q1_eUw_v7rezv5_TDBj9Ojvzks5qhAtQgaJpZM4JnNj_ .