search

practicalmeteor / meteor-sinon

Depreciated - Sinon.JS, wrapped for meteor
https://atmospherejs.com/practicalmeteor/sinon
Other
20 stars 11 forks source link

Please update to latest sinon-version 1.8 to allow enhanced stub-features #22

Open thebarty opened 7 years ago

thebarty commented 7 years ago

Hi guys,

I love this package and would love to continue using it.

I'd love to use the sinon 1.8 stubing-features, like stub.onCall(0).returns(), but it is NOT supported if I use this package. Can you guys upgrade to the latest sinon? It would be AWESSSOOOMEE!!!!

vincro commented 7 years ago

@thebarty you can run meteor npm install sinon and and then import sinon from 'sinon' at the head of your spec files and this will give you the latest version.

spasarok commented 7 years ago

This worked for me. Is there any benefit to using sinon from 'practicalmeteor:sinon' that I'd be losing by importing from 'sinon' instead?

vincro commented 7 years ago

@spasarok nothing that I have come across. unless @practicameteor is slipping extra code in that is undocumented.