search

practicalmeteor / meteor-sinon

Depreciated - Sinon.JS, wrapped for meteor
https://atmospherejs.com/practicalmeteor/sinon
Other
20 stars 11 forks source link

Update to sinon 1.12.2 #3

Closed DominikGuzei closed 9 years ago

robot-lavaina commented 9 years ago

Will do when I'm back from vacation.

ryneeverett commented 9 years ago

+1. Sinon is on 1.14.1 now.

I built v1.10.3 myself and diffed it with the script in this repo. The diff seem too significant to be due merely to compile dependency upgrades so I'm guessing it was manually edited, but I can't make much sense of the modifications.

Did changes to Sinon introduce new complications to packaging it for Meteor? @DominikGuzei, why did you stop maintaining your own meteor-sinon package in favor of this one?

ryneeverett commented 9 years ago

Well I ended up getting an updated version working with only minor modifications to the built script. It turned out that most of the additional lines I found in my v1.10.3 build are already in v1.14.1, which I find mystifying.

DominikGuzei commented 9 years ago

@ryneeverett I just needed this for practicalmeteor:munit but I also use my own version now :wink:

rbabayoff commented 9 years ago

Will update it myself soon. Will also try and get them to auto deploy it using https://autopublish.meteor.com/