Why does this extension now need data for all sites permission?

[Bandit]

As of the 1.6 update

[jnm]

I'm wondering if it was added for debugging and accidentally left in for the release? The actual changes for the 1.6 update are small and innocuous: https://github.com/pradeep-mishra/tab_suspender_firefox/commit/7808339d0f05e032207ce3182fb38518b9570836?w=1

I don't use the URL whitelisting feature, so I've declined the update for now.

[Bandit]

Yeah I saw that. I also noticed version 1.5 (the version I'm now using) was never added to the repo?

[pradeep-mishra]

1.5 was also published in github but i did not put that in comment. in version 1.6 i have added 15,20 minutes and 1 hour options in suspend after dropdown.

On Tue, Sep 15, 2020 at 8:54 AM James Nisbet notifications@github.com wrote:

Yeah I saw that. I also noticed version 1.5 (the version I'm now using) was never added to the repo?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pradeep-mishra/tab_suspender_firefox/issues/2#issuecomment-692439361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMZ3R3BKS6D7VQEKYGBMRDSF3M5JANCNFSM4RMDPYLA .

[Bandit]

Ok but why did you add the "all data for all sites" permission?

https://github.com/pradeep-mishra/tab_suspender_firefox/commit/7808339d0f05e032207ce3182fb38518b9570836#diff-4b1eb3dc48c4e16d49db5b42298fe654R20

[pradeep-mishra]

I dont remember I’ll check, it might be there for URL whitelisting or any unfinished feature. if its not required for now then will remove in 1.7

On Tue, Sep 15, 2020 at 9:59 AM James Nisbet notifications@github.com wrote:

Ok but why did you add the "all data for all sites" permission?

7808339#diff-4b1eb3dc48c4e16d49db5b42298fe654R20 https://github.com/pradeep-mishra/tab_suspender_firefox/commit/7808339d0f05e032207ce3182fb38518b9570836#diff-4b1eb3dc48c4e16d49db5b42298fe654R20

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/pradeep-mishra/tab_suspender_firefox/issues/2#issuecomment-692456446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMZ3R7RE5TJG5O2NHBMEWTSF3USVANCNFSM4RMDPYLA .

[LtqxWYEG]

Yeah. I hope you remove it again. Until then I'm not updating. I already chose your addon over others because they needed this permission for no reason. There really is no reason for it.

[pradeep-mishra]

removed all site permission please update to v 1.7

[jnm]

thank you! edit: also, i got the update automatically because it did not require any new permissions :raised_hands:

[LtqxWYEG]

Thank you :)