search

pradeepmouli / homebridge-isy-js

Homebridge platform plugin for the ISY series of home controllers from Universal Devices.
MIT License
28 stars 9 forks source link

FanLinc fan speeds are wrong #29

Open flmmkr1 opened 4 years ago

flmmkr1 commented 4 years ago

The FanLinc fan speeds that can be used are only 0%, 25%, 50%, 75%, and 100%. They should be as below to match correct functionality as in ISY and Insteon’s own software and keypad controls.

Off = 0% Low = 33% Med = 66% or 67% High = 100%

That’s how the previous plugin/versions functioned. Also, with the previous plugin we could set the fan speed to any percentage in the home app when adjusting the slider. Currently It can only be set to 0%, 25%, 50%, 75%, and 100% with the slider.

Also, when I set the fan speed using the keypad, the correct fan speed is not showing in HomeKit. This worked properly in the previous plugin/versions. For example, if I pressed Fan Low on the Insteon keypad, the fan speed would correctly show 33% in the Home app. Now it shows the wrong speed. Low shows as 25% and Med shows as 75%.

Lastly, it would be great to not be forced to add the light portion of the FanLinc module to HomeKit when there is no light in the fan. With the previous plugin/versions the parts of the FanLinc module could be included and excluded independently. Now they both have to be included, and even if you show them as separate tiles, both tiles have to appear as favorites if you only want one as a favorite. This functionality is far from ideal when the light part of the module is not being used.

pradeepmouli commented 4 years ago

I’ll look at the light part...i agree the light service shouldn’t be created if you don’t have a light node.... as for the speeds... the isy recently switched to 0/25/75/100 as speed values vs. 0/33/66/100... nonetheless it probably makes sense to map the latter on the hk-side to the former.

flmmkr1 commented 4 years ago

I wasn’t aware of the fan speed change in the change in the ISY. Is there a way to override that in ISY? Seems like such a huge jump from 25 to 75. Doesn’t make sense.

Thank you for looking into the light part.