Visibility of *BuilderSupport

[GoogleCodeExporter]

Currently, SegmentBuilderSupport and PropertyBuilderSupport are package 
protected although their methods are exposed through RecordBuilder and 
SegmentBuilder. 
I think it would be correct to make them public and instead make the 
constructor package protected. This way you still prohibit subclassing, but 
people are able to write methods that accept *BuilderSupport as a parameter.

The reason I'm asking this is because I'm building a small layer on top of 
beanio's Java config to make it even easier to configure in the Xtend language.

Original issue reported on code.google.com by st.oehme on 11 May 2013 at 5:29

[GoogleCodeExporter]

I just noticed that this is true for many other classes in org.beanio.builder

They should really be public or they should be interfaces. It seems odd to have 
public methods accept a type that is not publicly visible ;)

Original comment by st.oehme on 11 May 2013 at 6:56

[GoogleCodeExporter]

Yep, that makes senses.  Thanks the feedback!

Kevin

Original comment by kevin.s...@gmail.com on 12 May 2013 at 11:51

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by kevin.s...@gmail.com on 12 May 2013 at 11:52

• Added labels: Milestone-2.1.0.M2

[GoogleCodeExporter]

Snapshot JAR attached.

Original comment by kevin.s...@gmail.com on 2 Jun 2013 at 9:36

Attachments:

• beanio-2.1.0.SNAPSHOT.jar

[GoogleCodeExporter]

Original comment by kevin.s...@gmail.com on 16 Nov 2013 at 5:28

• Changed state: Fixed