search

pradel / create-react-app-esbuild

Use esbuild in your create-react-app for faster compilation, development and tests
MIT License
563 stars 35 forks source link

Upgrade dependencies #45

Closed martinerko closed 2 years ago

martinerko commented 2 years ago

react-scripts v 5.0 is out there and it works perfectly

pradel commented 2 years ago

Looks like craco is not yet supporting CRA 5, we should wait for them to support it before creating a new release here https://github.com/gsoft-inc/craco/issues/353

martinerko commented 2 years ago

Looks like craco is not yet supporting CRA 5, we should wait for them to support it before creating a new release here gsoft-inc/craco#353

The issue seems to be with the craco-* plugins (such as craco-less). I am already running this without any issue. Check ths out https://github.com/martinerko/react-scripts-typescript-craco-esbuild

pradel commented 2 years ago

I created a pr adding an example running on CRA 5 but getting the following error during builds https://github.com/pradel/create-react-app-esbuild/pull/48

Plugin "react" was conflicted between "package.json » eslint-config-react-app » /Users/leo/dev/github/pradel/create-react-app-esbuild/examples/cra-4/with-javascript/node_modules/eslint-config-react-app/base.js" and "BaseConfig » /Users/leo/dev/github/pradel/create-react-app-esbuild/node_modules/.pnpm/eslint-config-react-app@6.0.0_09f0dc14b8920a4aead8ce95b713775f/node_modules/eslint-config-react-app/base.js".

pradel commented 2 years ago

Managed to fix this issue but now the svgr plugin is not working anymore

pradel commented 2 years ago

Closing in favour of https://github.com/pradel/create-react-app-esbuild/pull/48 as it requires some changes to have all the features working.