pradel / create-react-app-esbuild

Use esbuild in your create-react-app for faster compilation, development and tests
MIT License
561 stars 34 forks source link

craco build errorring out on nullish Coalescing #66

Closed jschimmoeller closed 1 year ago

jschimmoeller commented 1 year ago

Issue: craco build throws this error:

versions: craco 5.9.0 craco-esbuild 0.5.1

` ./node_modules/vega-label/build/vega-label.module.js 557:33 Module parse failed: Unexpected token (557:33) You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders | return false; | }

let textWidth = d.textWidth ?? 0,

| dx, | dy, `

// craco.config.js ` const CracoEsbuildPlugin = require('craco-esbuild');

module.exports = { plugins: [{ plugin: CracoEsbuildPlugin }] }; `

I tried using the target in craco.config.js but no success.

Any advice ?

jschimmoeller commented 1 year ago

so i found out that the vega-label package is not building correctly which is causing this error.

opening a ticket with vega