search

pradel / node-instagram

Instagram api client for node that support promises.
MIT License
190 stars 27 forks source link

Update README.md #25

Closed khendrikse closed 6 years ago

khendrikse commented 6 years ago

I thought it might be a good idea to explain in the examples that you can (and in my experience, have to, but I could be wrong) send the acces_token along as a parameter when you call an endpoint. When I first tried doing it as explained in the README I got stuck because it expected you to provide an access token when creating the Instagram instance. Yet, first you have to get an access_token from the user, and to get this, you already need to have an instance of Instagram so that you can call instagram.getAuthorizationUrl. Putting the access_token in the endpoint examples might help people understand this process better.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling cd7579897ec533ca688c2fcc66cfd80a5a250925 on khendrikse:master into 991b3a78a79a3d0f54911d40314a36814d45b279 on pradel:master.

pradel commented 6 years ago

That's a great idea thank you! Maybe instead of modify all examples we can add one more with the explanation you provided for the pr description?

khendrikse commented 6 years ago

That would also be a great idea! Thank you!

Met vriendelijke groet, Karin Hendrikse

2017-12-04 20:05 GMT+01:00 Léo Pradel notifications@github.com:

That's a great idea thank you! Maybe instead of modify all examples we can add one more with the explanation you provided for the pr description?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pradel/node-instagram/pull/25#issuecomment-349070263, or mute the thread https://github.com/notifications/unsubscribe-auth/AdKTE_qTvOD-_S6rT3yz-f02roUbEOFNks5s9EKKgaJpZM4QzX1K .

pradel commented 6 years ago

Do you want to update or create a new pr?