Closed alexkrautmann closed 2 years ago
I can also make this behavior configurable via a prop, let me know if you think that makes sense.
@alexkrautmann thanks for the pr it looks like a great addition! Would be great to make it configurable via a prop indeed :)
I also think that by default the value should be false (to avoid being a breaking change.)
Merging #475 (a9c0825) into master (23cccc6) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 6 6
Lines 179 179
Branches 66 65 -1
=======================================
Hits 174 174
Misses 5 5
Impacted Files | Coverage Δ | |
---|---|---|
react-responsive-modal/src/useScrollLock.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 23cccc6...a9c0825. Read the comment docs.
Hi guys! Look forward to this addition! Do you know when it will be finished?
closing in favor of https://github.com/pradel/react-responsive-modal/pull/484
From the body-scroll-lock README:
Without reserveScrollBarGap (current behavior):![without-reserveScrollBarGap](https://user-images.githubusercontent.com/5550247/117516067-9fa2d480-af5d-11eb-84e9-683e2f617702.gif)
With reserveScrollBarGap:![with-reserveScrollBarGap](https://user-images.githubusercontent.com/5550247/117516087-b0ebe100-af5d-11eb-9089-ea8b7413d891.gif)