search

pradel / react-responsive-modal

Simple responsive react modal
https://react-responsive-modal.leopradel.com/
MIT License
604 stars 95 forks source link

feat: add optional reserveScrollBarGap #484

Closed huksley closed 2 years ago

huksley commented 2 years ago

improved #475 for more information see original PR Optional reserveScrollBarGap={true}

codecov[bot] commented 2 years ago

Codecov Report

Merging #484 (ca6b224) into master (61c3493) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head ca6b224 differs from pull request most recent head a19e9d0. Consider uploading reports for the commit a19e9d0 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   95.23%   95.26%   +0.02%     
==========================================
  Files           6        6              
  Lines         189      190       +1     
  Branches       70       69       -1     
==========================================
+ Hits          180      181       +1     
  Misses          9        9
Impacted Files Coverage Δ
react-responsive-modal/src/index.tsx 100.00% <100.00%> (ø)
react-responsive-modal/src/useScrollLock.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61c3493...a19e9d0. Read the comment docs.

pradel commented 2 years ago

@huksley thanks for the pr! Could you change the size so the CI pass please?

huksley commented 2 years ago

@pradel Done